PWGEM/Dilepton: bug fix after #8100 and #8146 #8170
Merged
+18
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsekihat
requested review from
alibuild,
mikesas,
rbailhac,
ivorobye and
feisenhu
as code owners
dsekihat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PWGEM/Dilepton: bug fix
#8100
sign of M_PI/2. was wrong.
.2 was wrong.
#8146
Histogram name was wrong.
if-else logic was wrong.
The linear cut is part of the elliptic cut. Namely, the linear deta cut is equivalent at the limit of dphi-> infinity.
If one wants to apply linear deta cut, one should set cfg_min_dphi = 1e+10, and vice versa.